-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tabs extended media]: React wrapper – not able to access other tabs with VO instructions #8139
Comments
@andy-blum Can you take a look at this issue and see if it's related to the one you just opened a PR for (#8357)? Feels like the VO issues that @oliviaflory mentioned here are the same as what you're working on for the WC version, but let me know if that's not the case. |
The main thing I'd recommend to @oliviaflory (and anyone else testing VoiceOver) is to do it in safari.
|
Also worth noting that Deque has a list of ideal screen reader/browser pairings |
@kennylam I'm going to move this issue out of our Innovation Team queue as this is related to the WC React Wrapper and one that we're not prioritizing at the moment. |
@oliviaflory I just took a look at this and the behavior comes from Carbon's tab component. Tabbing in this element toggles between the tab and tab content. In order to choose other tabs, only the left/right cursor keys work, for both Chrome and Safari. One notable difference is that Carbon's version does not cause the screen reader to announce any key combo to select a tab. The tabs are selected the moment they are in focus and active. Seems like something in in the dotcom component is making the screen reader add the additional instructions with the key combo, which is not needed. It looks like we only have one issue here. That is the additional VoiceOver instructions with key combos that do nothing (which we should fix). The Carbon |
Popping back into this issue after getting the request to review, and I'm feeling pretty confident that the issue described isn't really an issue. When using VO, the
The
Since all of our tab content is already in the DOM on page load, there should be effectively zero latency, so we should automatically activate tabs on focus. This means that Testing the canary version of this component, there are a few patterns that I'm seeing that should be changed:
|
We've marked this issue as stale because there hasn't been any activity for 60 days. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
Description
I am not able to select the second, third or fourth tab in Tabs extended or Tabs extended – with media using the keyboard and voice over on Desktop
VO instructs the user to press
control
+option
+space
to select a tab and it doesn't work, I see no changes in the selected state (all tabs content are the same).VO is also reading out the tabs as first tab: "1 of 8"; second tab "3 of 8", which seems a bit strange? Is that the expected behavior and it's indicating a tab has two sections, the heading and the content?
Tabs.extended.media-keyboard-.2022-01-25.at.9.03.56.AM.mov
This seems to be present in Production
Workaround
I am able to select other tabs by using:
control
+option
+shift
+down arrow
, thencontrol
+option
+space
, thentab
to navigate into the tab content area.Component(s) impacted
Tabs extended
Tabs extended with media
Browser
Chrome
Carbon for IBM.com version
1.15.0 rc 1
Severity
Severity 2 = Aspects of design is broken, and impedes users in a significant way, but there is a way to complete their tasks. Affects major functionality, has a workaround.
Application/website
Carbon for IBM.com
Package
@carbon/ibmdotcom-react
CodeSandbox example
https://carbon-design-system.github.io/carbon-for-ibm-dotcom/next/web-components-react/?path=/story/components-tabs-extended--default
Steps to reproduce the issue (if applicable)
No response
Release date (if applicable)
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: