Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-wrapper]: component does not always update with knob changes #6995

Closed
ariellalgilmore opened this issue Aug 26, 2021 · 5 comments
Closed
Labels
bug Something isn't working dev Needs some dev work inactive severity 3 Affects minor functionality, has a workaround storybook

Comments

@ariellalgilmore
Copy link
Member

ariellalgilmore commented Aug 26, 2021

Detailed description

Describe in detail the issue you're having.

Is this a feature request (new component, new icon), a bug, or a general
issue?
bug

Is this issue related to a specific component?

multiple react-wrapper components specifically though CTA Section heading and changing the content items

What did you expect to happen? What happened instead? What would you like to
see changed?

When changing the heading the knob the text does not update and when changing to the statistics content item the alignment is off. It works correctly though when opening the story in a new window.

Additional information

  • could be caused by react usually taking in the text data as an attribute instead of having it be “inline” like in web components
@ariellalgilmore ariellalgilmore added the bug Something isn't working label Aug 26, 2021
@RobertaJHahn RobertaJHahn added dev Needs some dev work storybook package: web components Work necessary for the IBM.com Library web components package labels Aug 27, 2021
@RobertaJHahn RobertaJHahn added the severity 3 Affects minor functionality, has a workaround label Aug 31, 2021
@jeffchew jeffchew added this to the Sprint 21-21 milestone Sep 8, 2021
@jeffchew jeffchew modified the milestones: Sprint 21-21, Sprint 21-22 Oct 6, 2021
@jeffchew jeffchew modified the milestones: Sprint 21-22, Sprint 21-23 Oct 18, 2021
@RobertaJHahn RobertaJHahn removed the package: web components Work necessary for the IBM.com Library web components package label Oct 25, 2021
@andysherman2121 andysherman2121 self-assigned this Nov 29, 2021
@andysherman2121
Copy link
Contributor

Knobs aren't updating due to storybookjs/storybook#16682
This is being blocked until the storybook team fixes the issue

@RobertaJHahn RobertaJHahn removed this from the Sprint 21-24 milestone Dec 6, 2021
@RobertaJHahn RobertaJHahn added this to the Sprint 21-25 milestone Dec 6, 2021
@jeffchew jeffchew removed this from the Sprint 21-25 milestone Jan 4, 2022
@stale
Copy link

stale bot commented Apr 19, 2022

We've marked this issue as stale because there hasn't been any activity for 60 days. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Apr 19, 2022
@jeffchew
Copy link
Member

@ariellalgilmore saw that this was flagged by stalebot, will upgrading to storybook 6 / controls fix this issue?

@stale stale bot removed the inactive label Apr 19, 2022
@ariellalgilmore
Copy link
Member Author

@jeffchew i was wondering the same thing. will keep this issue in mind

@stale
Copy link

stale bot commented May 27, 2023

We've marked this issue as stale because there hasn't been any activity for 60 days. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label May 27, 2023
@andy-blum andy-blum closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev Needs some dev work inactive severity 3 Affects minor functionality, has a workaround storybook
Projects
Status: Done
Development

No branches or pull requests

10 participants