Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Link with icon] React: icon position when text wraps to 2 lines #6837

Closed
RobertaJHahn opened this issue Aug 9, 2021 · 3 comments
Closed

[Link with icon] React: icon position when text wraps to 2 lines #6837

RobertaJHahn opened this issue Aug 9, 2021 · 3 comments
Assignees
@BrunnoM7
Labels
bug Something isn't working dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package severity 3 Affects minor functionality, has a workaround
Milestone
Sprint 21-23

Comments

@RobertaJHahn
Copy link

RobertaJHahn commented Aug 9, 2021 •
edited
Loading

Currently link with icon is not showing the correct behavior when link text wraps to 2 lines. Icon snaps to right-aligned to the container, and creates a weird gap between text and icon. This could happen when text is too long, or when screen size is narrow, and is influencing several dependent components such as Link list, Link list section, and Content group banner

This is similar problem to (#5740 )

This bug was fixed in Web Components under issue (#5705 ) and PR (#6812 )
See this issues for more details, if needed. Fix done by Andrew Wang

Current

Apr-02-2021 16-52-42.gif

image.png
@RobertaJHahn RobertaJHahn added dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package severity 3 Affects minor functionality, has a workaround bug Something isn't working labels Aug 9, 2021
This was referenced Aug 9, 2021
Closed
Merged
@jeffchew jeffchew modified the milestones: Sprint 21-22, Sprint 21-23 Oct 18, 2021
@BrunnoM7 BrunnoM7 self-assigned this Nov 8, 2021
@BrunnoM7
Copy link
Contributor

I have the impression that this issue was fixed in a preview PR. Would someone please take a second look at this? @shixiedesign @DragosRistici @photodow

@emyarod
Copy link
Member

emyarod commented Nov 18, 2021

may have been resolved in #6812

@shixiedesign
Copy link
Contributor

shixiedesign commented Nov 18, 2021 •
edited
Loading

Yes this can be closed. There's still a bug in alignment in React Link List - end of section but we can consider it out of scope of this ticket. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrunnoM7 BrunnoM7

Labels
bug Something isn't working dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package severity 3 Affects minor functionality, has a workaround
Projects
None yet
Milestone
Sprint 21-23
Development

No branches or pull requests
5 participants
@jeffchew @emyarod @BrunnoM7 @shixiedesign @RobertaJHahn