Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web component: AEM Link List styling changes Design PR review #4900

Closed
5 tasks
ibmdotcom-bot opened this issue Jan 14, 2021 · 4 comments
Closed
5 tasks

Web component: AEM Link List styling changes Design PR review #4900

ibmdotcom-bot opened this issue Jan 14, 2021 · 4 comments
Assignees
Labels
adopter: AEM used when component or pattern will be used by this adopter adopter support design Applied to all issues assigned to the design team members. Filter used in planning meetings dev complete package: web components Work necessary for the IBM.com Library web components package Sprint Must Have
Milestone

Comments

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 14, 2021

User Story

As a [user role below]:
DDS Designer and Developer

I need to:
test the AEM Link List styling changes

so that I can:
be sure the developer's code correctly works as designed

Additional Information

Tasks

Ensure the AEM Link List styling changes component has been tested and reviewed by design + dev.

Acceptance criteria

  • Pattern is reviewed by designer and design defects are identified
  • New issues are opened to log individual defects
  • Screenshots of as-is and to-be design should be added to the issue when needed
  • Developer associated with building the pattern is assigned to the new issues
  • Appropriate labels are added to the issue eg. bug, dev
@ibmdotcom-bot ibmdotcom-bot added design Applied to all issues assigned to the design team members. Filter used in planning meetings package: web components Work necessary for the IBM.com Library web components package labels Jan 14, 2021
@RobertaJHahn RobertaJHahn changed the title Web component: AEM Link List styling shanges Design PR review template Web component: AEM Link List styling shanges Design PR review Jan 14, 2021
@RobertaJHahn RobertaJHahn added adopter support adopter: AEM used when component or pattern will be used by this adopter labels Jan 14, 2021
@RobertaJHahn RobertaJHahn added this to the Sprint 21-02 milestone Jan 14, 2021
@RobertaJHahn RobertaJHahn changed the title Web component: AEM Link List styling shanges Design PR review Web component: AEM Link List styling changes Design PR review Jan 14, 2021
@RobertaJHahn
Copy link

@StephanieHoman This component is ready to be tested. @raphaelamadeu please add the links for Stephanie to do here testing to this issue.

@raphaelamadeu-zz
Copy link
Contributor

@StephanieHoman
Copy link

StephanieHoman commented Jan 28, 2021

@raphaelamadeu Three columns looks great, thanks! I noticed when there are 3 or less links, the list remains in two columns. For 1-3 links, it should be one column. Is this a new request I need to create?
Screen Shot 2021-01-28 at 9 49 17 AM

@RobertaJHahn
Copy link

@StephanieHoman Please create a bug. (Link to the instructions are included in the Additional Information section.) We'll get the fix prioritized in the next sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: AEM used when component or pattern will be used by this adopter adopter support design Applied to all issues assigned to the design team members. Filter used in planning meetings dev complete package: web components Work necessary for the IBM.com Library web components package Sprint Must Have
Projects
None yet
Development

No branches or pull requests

4 participants