Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply expressive tokens to Carbon for IBM.com component specs #4750

Closed
13 tasks
oliviaflory opened this issue Dec 18, 2020 · 3 comments
Closed
13 tasks

Apply expressive tokens to Carbon for IBM.com component specs #4750

oliviaflory opened this issue Dec 18, 2020 · 3 comments
Labels
design: specs design Applied to all issues assigned to the design team members. Filter used in planning meetings

Comments

@oliviaflory
Copy link
Contributor

oliviaflory commented Dec 18, 2020

User Story

As a [user role below]:

DDS designer

I need to:

update all Carbon for IBM.com components that use productive tokens to use expressive theme tokens

so that :

components use one type scale and are more consistent for our adopters

Additional information

Here is a list of the components that need updating and which token they should use with the expressive theme applied:

  • Leaving IBM label above link --> $label-01

  • callout with media image caption --> $caption-01

  • Card card eyebrow --> $label-01

  • Card video duration --> check what type style is being applied, currently seems like it should be 16px

  • image with caption image caption --> $caption-01

  • locale modal modal header label (top right) --> $label-01

  • locale modal Search heading (this page is available in...) --> $heading-02

  • content item horizontal content item horizontal item eyebrow --> $label-01

  • video player video player video caption --> $caption-01

  • logo grid check if card link should be semibold? --> $heading-01 or 02

Note: we will not be removing the productive mixin from the mega menu, decided in #4341

Acceptance criteria

  • Productive tokens are removed from all component specs listed above
  • Expressive tokens listed above are applied
  • Designer (Olivia) reviewed all changes
@oliviaflory oliviaflory added design Applied to all issues assigned to the design team members. Filter used in planning meetings design: specs labels Dec 18, 2020
@stale
Copy link

stale bot commented Mar 10, 2021

We've marked this issue as stale because there hasn't been any activity for 60 days. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Mar 10, 2021
@oliviaflory
Copy link
Contributor Author

Not stale

@stale stale bot removed the inactive label Mar 10, 2021
@RobertaJHahn
Copy link

Done. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: specs design Applied to all issues assigned to the design team members. Filter used in planning meetings
Projects
None yet
Development

No branches or pull requests

2 participants