Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masthead overflow – overflow content shifting doesn't match functional spec #4188

Closed
oliviaflory opened this issue Oct 8, 2020 · 2 comments
Assignees
Labels
bug Something isn't working dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package severity 3 Affects minor functionality, has a workaround Sprint Must Have
Milestone

Comments

@oliviaflory
Copy link
Contributor

oliviaflory commented Oct 8, 2020

Detailed description

Describe in detail the issue you're having.

  • Included the sprint must have label as this overflow feature is committed for the Nov release
    Per the functional specs: if there is a partially hidden item on either side treat that item as the first item of the next section/panel/view

However the first partially hidden item is not in full view in the next section/panel/view:
first partially covered item placement Oct-08-2020 14-49-54

Intended behavior: code sandbox example
first partially visible prototypeOct-08-2020 15-08-18

Is this a feature request (new component, new icon), a bug, or a general
issue?

bug or general, does not follow the functional specs

Is this issue related to a specific component?

masthead

What did you expect to happen? What happened instead? What would you like to
see changed?

What browser are you working in?

Chrome

What version of the IBM.com Library are you using?

Canary

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

October release

Steps to reproduce the issue

  1. Step one
  2. Step two
  3. Step three
  4. etc.

Additional information

  • Screenshots or code
  • Notes
@oliviaflory oliviaflory added bug Something isn't working package: react Work necessary for the Carbon for IBM.com react components package labels Oct 8, 2020
@jeffchew
Copy link
Member

jeffchew commented Oct 9, 2020

@oliviaflory not sure if we can make adjustments for this before code freeze. Can this go into the next release?

cc: @ariellalgilmore @RobertaJHahn @ljcarot @wonilsuhibm

@RobertaJHahn RobertaJHahn added dev Needs some dev work severity 3 Affects minor functionality, has a workaround labels Oct 13, 2020
@RobertaJHahn RobertaJHahn added this to the Sprint 20-22 milestone Oct 13, 2020
@RobertaJHahn
Copy link

This behavior will be implemented as documented in the functional specs. If the last option on the right is partially visible the menu will slide to the right for the small amount needed to expose the entire option. @photodow will find where the behavior is documented in the functional specs. If not documented, he will update the functional specs. This decision was made in a meeting with the India accessibility team members.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev Needs some dev work package: react Work necessary for the Carbon for IBM.com react components package severity 3 Affects minor functionality, has a workaround Sprint Must Have
Projects
None yet
Development

No branches or pull requests

7 participants