Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Services: Make modules tree-shakable #2881

Closed
asudoh opened this issue Jun 24, 2020 · 3 comments
Closed

Services: Make modules tree-shakable #2881

asudoh opened this issue Jun 24, 2020 · 3 comments
Labels
dev Needs some dev work housekeeping icebox used for all issues in the Icebox pipeline. Stalebot ignores these issues when this label is added. package: services Work necessary for the Carbon for IBM.com services package priority: low

Comments

@asudoh
Copy link
Contributor

asudoh commented Jun 24, 2020 •
edited by jeffchew
Loading

The problem

Though we know that import { namedImport } from 'package-name' has negative effects on application bundle size and build time and we have migrated away from it in our internal code, it's easier to use for our adopters and still want to provide good support for this usage.

The solution

Add /*#__PURE__*/ annotations (with wrapping contents in IIFE as necessary).

Additional Information
@asudoh asudoh added the Feature request A new adopter requested feature label Jun 24, 2020
@asudoh asudoh self-assigned this Jun 24, 2020
@RobertaJHahn RobertaJHahn added dev Needs some dev work package: services Work necessary for the Carbon for IBM.com services package priority: low and removed Feature request A new adopter requested feature labels Jul 13, 2020
@RobertaJHahn RobertaJHahn added this to the Sprint 20-16 milestone Jul 13, 2020
@jeffchew jeffchew modified the milestones: Sprint 20-16, Sprint 20-20 Aug 10, 2020
@jeffchew
Copy link
Member

@RobertaJHahn @asudoh moving this one out.

@RobertaJHahn RobertaJHahn removed this from the Sprint 21-06 milestone Mar 25, 2021
@RobertaJHahn RobertaJHahn added the icebox used for all issues in the Icebox pipeline. Stalebot ignores these issues when this label is added. label Mar 25, 2021
@RobertaJHahn
Copy link

Decided to move to icebox in the March 22, 2021 engineering issues refinement meeting.

@RobertaJHahn
Copy link

Jeff to discuss in engineering huddle.

@andy-blum andy-blum closed this as not planned Won't fix, can't repro, duplicate, stale Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev Needs some dev work housekeeping icebox used for all issues in the Icebox pipeline. Stalebot ignores these issues when this label is added. package: services Work necessary for the Carbon for IBM.com services package priority: low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@asudoh @jeffchew @ljcarot @andy-blum @RobertaJHahn