Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Component] Dotcom shell #10809

Closed
5 tasks
Tracked by #10715
oliviaflory opened this issue Aug 10, 2023 · 0 comments
Closed
5 tasks
Tracked by #10715

[Component] Dotcom shell #10809

oliviaflory opened this issue Aug 10, 2023 · 0 comments
Assignees
Labels
dev Needs some dev work v2

Comments

@oliviaflory
Copy link
Contributor

oliviaflory commented Aug 10, 2023

Dotcom Shell

  • Depends on Masthead v2 (AEM)
  • Depends on Footer

Acceptance criteria

For all components, some basic acceptance criteria should be observed when working on them:

  • also update React wrapper
  • update Storybook docs
  • use visual design checklist before opening a PR (with emphasis on numbers 1, 2, and 6)
  • update migration guide if necessary (here is a good example of how the guide could look)
  • update unit tests where necessary (tracked in [Components]: Update @carbon/ibmdotcom-web-components v2 unit tests Epic #10369)
  • Note: Currently there is no standardization of tests, duplicate and/or redundant tests, and inconsistency in UI testing. The team consensus is to modify the tests as necessary (markup/name changes, etc) but to give this lower priority if it becomes a blocker in completing a particular component. The tests will get an overhaul in the future, so it is unnecessary to get them completely updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Needs some dev work v2
Projects
Archived in project
Development

No branches or pull requests

3 participants