Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expressive theme – Progress indicator #1039

Closed
1 task
oliviaflory opened this issue Jan 14, 2020 · 3 comments
Closed
1 task

Expressive theme – Progress indicator #1039

oliviaflory opened this issue Jan 14, 2020 · 3 comments
Assignees
Labels
dev Needs some dev work package: styles Work necessary for the Carbon for IBM.com styles package priority: medium
Milestone

Comments

@oliviaflory
Copy link
Contributor

Update for default, interactive and vertical variations:

Screen Shot 2020-01-14 at 4 32 30 PM

  • update status icons to 20x20 px
@oliviaflory oliviaflory added dev Needs some dev work priority: medium package: styles Work necessary for the Carbon for IBM.com styles package labels Jan 14, 2020
@oliviaflory oliviaflory added this to the Sprint 20-01 milestone Jan 14, 2020
@annawen1 annawen1 self-assigned this Jan 15, 2020
@annawen1
Copy link
Member

Looks like bx--progress-step--current and bx--progress-step--incomplete svg icons don't scale accordingly when I bump up the width and height to 20px

Screen Shot 2020-01-16 at 10 47 26 AM

Looking at the carbon code

if (current) {
      return (
        <svg>
          <path d="M 7, 7 m -7, 0 a 7,7 0 1,0 14,0 a 7,7 0 1,0 -14,0" />
          <title>{description}</title>
        </svg>
      );
    }
    
     ....

    return (
      <svg>
        <title>{description}</title>
        <path d="M8 1C4.1 1 1 4.1 1 8s3.1 7 7 7 7-3.1 7-7-3.1-7-7-7zm0 13c-3.3 0-6-2.7-6-6s2.7-6 6-6 6 2.7 6 6-2.7 6-6 6z" />
      </svg>

There are no attributes for the those svg elements - I think we need the viewBox attribute in order for the current and incomplete to scale. Will submit a ticket to carbon to see if we can get that in

CC @oliviaflory @joshblack

@annawen1
Copy link
Member

ticket opened: carbon-design-system/carbon#5086

@annawen1
Copy link
Member

PR has been submitted to Carbon: carbon-design-system/carbon#5122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Needs some dev work package: styles Work necessary for the Carbon for IBM.com styles package priority: medium
Projects
None yet
Development

No branches or pull requests

3 participants