Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Card – Pictogram] Pictogram placement and body reveal #10127

Closed
10 tasks done
RichKummer opened this issue Feb 23, 2023 · 2 comments
Closed
10 tasks done

[Card – Pictogram] Pictogram placement and body reveal #10127

RichKummer opened this issue Feb 23, 2023 · 2 comments
Assignees
Labels
design Applied to all issues assigned to the design team members. Filter used in planning meetings v2: prep preparation items for Carbon for IBM.com V2 website used for Carbon for ibm.com website work

Comments

@RichKummer
Copy link

RichKummer commented Feb 23, 2023

We need to add website guidance to encourage using the bottom alignment (pattern guidance). The option to toggle between top and bottom alignment will stay in v2.

We should also review the body copy reveal on hover to see if there are accessibility or interaction concerns. Add border to bring in line with card updates for v2.

Guidance updates

  • Update website language to encourage bottom alignment.
  • Review website changes with Jeannie, Olivia, and Rich
  • Deploy website guidance changes – #1555
  • Add description in Figma kit to encourage bottom alignment (make the default)
  • Add dev story to update default to bottom alignment, if needed – [card – pictogram]: Add default for bottom alignment #10195

Body copy reveal

@RichKummer RichKummer added design Applied to all issues assigned to the design team members. Filter used in planning meetings v2: prep preparation items for Carbon for IBM.com V2 website used for Carbon for ibm.com website work labels Feb 23, 2023
@RichKummer RichKummer self-assigned this Feb 27, 2023
@RichKummer RichKummer moved this to Doing in Carbon for IBM.com Feb 27, 2023
@RichKummer
Copy link
Author

RichKummer commented Mar 1, 2023

Discussion with a11y notes

Image

  • Border added to card globally should help indicate that the card – pictogram is interactive
  • Pictogram is needed by card – pictogram, it cannot be removed
  • Mobile displays all info in overflow version. Should this replace card – pictogram's hover interaction, or be an added variant?

@RichKummer
Copy link
Author

Design crit 03/02/23

  • Gower's feedback for the hover reveal was that users may miss the title when focusing. Someone using a zoom feature in their browser may also miss the title as it animates away while the cursor is passing over the card.
  • In a group, the hover might be chaotic with some content appearing/disappearing.
  • Body copy should be optional, and resize the button down to an aspect ratio.
  • We should remove the hover reveal, and instead display all content without hiding behind a hover. This makes the card – pictogram more accessible and ensure they can see the most important takeaways in a single view.

@RichKummer RichKummer moved this from Doing to Review in Carbon for IBM.com Mar 7, 2023
@RichKummer RichKummer moved this from Review to Doing in Carbon for IBM.com Mar 7, 2023
@RichKummer RichKummer moved this from Doing to Review in Carbon for IBM.com Mar 9, 2023
@RichKummer RichKummer moved this from Review to Done in Carbon for IBM.com Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Applied to all issues assigned to the design team members. Filter used in planning meetings v2: prep preparation items for Carbon for IBM.com V2 website used for Carbon for ibm.com website work
Projects
Archived in project
Development

No branches or pull requests

1 participant