From dc0d0f2a7acb295f3dc8d0fad1294e40467523fd Mon Sep 17 00:00:00 2001 From: Jeff Chew Date: Mon, 1 Feb 2021 08:52:09 -0500 Subject: [PATCH 1/5] chore(support): updating support roster for sprint 3 --- .github/ISSUE_TEMPLATE/bug_report.md | 2 +- .github/ISSUE_TEMPLATE/contribution_request.md | 2 +- .github/ISSUE_TEMPLATE/feature_request.md | 2 +- .github/ISSUE_TEMPLATE/question.md | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 0cea654d601..b79a6638ff9 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -2,7 +2,7 @@ name: Bug Report 🐛 about: Something isn't working as expected? Here is the right place to report. labels: bug -assignees: jeffchew, wonilsuhibm, ljcarot, RobertaJHahn, oliviaflory, IgnacioBecerra +assignees: jeffchew, wonilsuhibm, ljcarot, RobertaJHahn, kennylam --- diff --git a/.github/ISSUE_TEMPLATE/question.md b/.github/ISSUE_TEMPLATE/question.md index 02b23c3e80f..26e98c3285a 100644 --- a/.github/ISSUE_TEMPLATE/question.md +++ b/.github/ISSUE_TEMPLATE/question.md @@ -2,7 +2,7 @@ name: Question 🤔 about: Usage question or discussion about Carbon for IBM.com. labels: question -assignees: jeffchew, wonilsuhibm, ljcarot, RobertaJHahn, oliviaflory, IgnacioBecerra +assignees: jeffchew, wonilsuhibm, ljcarot, RobertaJHahn, kennylam --- diff --git a/.github/ISSUE_TEMPLATE/question.md b/.github/ISSUE_TEMPLATE/question.md index 26e98c3285a..5b445b2373a 100644 --- a/.github/ISSUE_TEMPLATE/question.md +++ b/.github/ISSUE_TEMPLATE/question.md @@ -2,7 +2,7 @@ name: Question 🤔 about: Usage question or discussion about Carbon for IBM.com. labels: question -assignees: jeffchew, wonilsuhibm, ljcarot, RobertaJHahn, kennylam +assignees: jeffchew, wonilsuhibm, ljcarot, RobertaJHahn, guilhermelMoraes --- --- .../__snapshots__/storyshots.test.js.snap | 498 ++++++++++++++++-- .../__stories__/CTASection.stories.js | 12 +- .../src/components/CalloutData/CalloutData.js | 4 +- .../CardSectionCarousel.stories.js | 2 +- .../__stories__/CardSectionSimple.stories.js | 3 +- .../Carousel/__stories__/Carousel.stories.js | 4 +- .../src/components/DotcomShell/DotcomShell.js | 4 +- .../src/components/Footer/LanguageSelector.js | 9 +- .../react/src/components/Footer/LegalNav.js | 4 +- .../src/components/LeadSpace/LeadSpace.js | 29 +- .../LeadspaceWithSearch.js | 44 +- .../LeadspaceWithSearch.stories.js | 4 +- .../react/src/components/LinkList/LinkList.js | 6 +- .../Masthead/MastheadMegaMenu/MegaMenu.js | 6 +- .../UIShell/HeaderMenu.js | 4 +- .../internal/components/Callout/Callout.js | 4 +- .../ConditionalWrapper/ConditionalWrapper.js | 4 +- 17 files changed, 522 insertions(+), 119 deletions(-) diff --git a/packages/react/src/__tests__/__snapshots__/storyshots.test.js.snap b/packages/react/src/__tests__/__snapshots__/storyshots.test.js.snap index 3c497f81421..826b981d2db 100644 --- a/packages/react/src/__tests__/__snapshots__/storyshots.test.js.snap +++ b/packages/react/src/__tests__/__snapshots__/storyshots.test.js.snap @@ -1699,18 +1699,24 @@ exports[`Storyshots Components|CTASection Default 1`] = ` "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, Object { "copy": "Primary button", "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, ], "style": "button", @@ -1774,18 +1780,24 @@ exports[`Storyshots Components|CTASection Default 1`] = ` "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, Object { "copy": "Primary button", "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, ], "style": "button", @@ -1838,18 +1850,24 @@ exports[`Storyshots Components|CTASection Default 1`] = ` "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, Object { "copy": "Primary button", "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, ] } @@ -1870,18 +1888,24 @@ exports[`Storyshots Components|CTASection Default 1`] = ` "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, Object { "copy": "Primary button", "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, ] } @@ -1910,18 +1934,24 @@ exports[`Storyshots Components|CTASection Default 1`] = ` "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, Object { "copy": "Primary button", "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, ] } @@ -1942,7 +1972,12 @@ exports[`Storyshots Components|CTASection Default 1`] = ` iconDescription="right arrow icon" kind="tertiary" onClick={[Function]} - renderIcon={null} + renderIcon={ + Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + } + } size="default" tabIndex={0} target={null} @@ -1960,6 +1995,41 @@ exports[`Storyshots Components|CTASection Default 1`] = ` target={null} > Secondary button + @@ -1975,7 +2045,12 @@ exports[`Storyshots Components|CTASection Default 1`] = ` iconDescription="right arrow icon" kind="primary" onClick={[Function]} - renderIcon={null} + renderIcon={ + Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + } + } size="default" tabIndex={0} target={null} @@ -1993,6 +2068,41 @@ exports[`Storyshots Components|CTASection Default 1`] = ` target={null} > Primary button + @@ -2064,18 +2174,24 @@ exports[`Storyshots Components|CTASection With Content Items 1`] = ` "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, Object { "copy": "Primary button", "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, ], "style": "button", @@ -2133,18 +2249,24 @@ exports[`Storyshots Components|CTASection With Content Items 1`] = ` "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, Object { "copy": "Primary button", "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, ], "style": "button", @@ -2219,18 +2341,24 @@ exports[`Storyshots Components|CTASection With Content Items 1`] = ` "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, Object { "copy": "Primary button", "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, ] } @@ -2251,18 +2379,24 @@ exports[`Storyshots Components|CTASection With Content Items 1`] = ` "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, Object { "copy": "Primary button", "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, ] } @@ -2291,18 +2425,24 @@ exports[`Storyshots Components|CTASection With Content Items 1`] = ` "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, Object { "copy": "Primary button", "href": "https://example.com/", "iconDescription": "right arrow icon", "onClick": [Function], - "renderIcon": null, + "renderIcon": Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + }, "target": null, - "type": "default", + "type": "local", }, ] } @@ -2323,7 +2463,12 @@ exports[`Storyshots Components|CTASection With Content Items 1`] = ` iconDescription="right arrow icon" kind="tertiary" onClick={[Function]} - renderIcon={null} + renderIcon={ + Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + } + } size="default" tabIndex={0} target={null} @@ -2341,6 +2486,41 @@ exports[`Storyshots Components|CTASection With Content Items 1`] = ` target={null} > Secondary button + @@ -2356,7 +2536,12 @@ exports[`Storyshots Components|CTASection With Content Items 1`] = ` iconDescription="right arrow icon" kind="primary" onClick={[Function]} - renderIcon={null} + renderIcon={ + Object { + "$$typeof": Symbol(react.forward_ref), + "render": [Function], + } + } size="default" tabIndex={0} target={null} @@ -2374,6 +2559,41 @@ exports[`Storyshots Components|CTASection With Content Items 1`] = ` target={null} > Primary button + @@ -3501,7 +3721,7 @@ exports[`Storyshots Components|Card Section Carousel Default 1`] = ` library with a @@ -11156,15 +11376,15 @@ exports[`Storyshots Components|CardSectionSimple Default 1`] = ` ] } heading="Aliquam condimentum interdum" - theme="" + theme="white" >
@@ -44353,6 +44573,7 @@ exports[`Storyshots Components|Dotcom Shell Default (footer language only) 1`] = defaultValue="en" disabled={false} helperText="" + id="bx--language-selector" inline={false} invalid={false} invalidText="" @@ -44369,6 +44590,7 @@ exports[`Storyshots Components|Dotcom Shell Default (footer language only) 1`] = > @@ -44380,12 +44602,14 @@ exports[`Storyshots Components|Dotcom Shell Default (footer language only) 1`] = className="bx--select-input" data-autoid="dds--language-selector__select" defaultValue="en" + id="bx--language-selector" onChange={[Function]} text="English" >
  • @@ -89599,6 +89866,7 @@ exports[`Storyshots Components|Dotcom Shell With short footer (language only) 1` defaultValue="en" disabled={false} helperText="" + id="bx--language-selector" inline={false} invalid={false} invalidText="" @@ -89615,6 +89883,7 @@ exports[`Storyshots Components|Dotcom Shell With short footer (language only) 1` > @@ -89626,12 +89895,14 @@ exports[`Storyshots Components|Dotcom Shell With short footer (language only) 1` className="bx--select-input" data-autoid="dds--language-selector__select" defaultValue="en" + id="bx--language-selector" onChange={[Function]} text="English" >
  • @@ -119106,6 +119498,7 @@ exports[`Storyshots Components|Masthead With L 1 1`] = ` } } key=".$Lorem ipsum dolor sit amet" + refs={[Function]} role="none" > @@ -119308,6 +119701,7 @@ exports[`Storyshots Components|Masthead With L 1 1`] = ` data-autoid="dds--masthead-alt__l1-nav0-item0" href="" key=".$Link 2" + refs={[Function]} role="none" >
  • diff --git a/packages/react/src/components/CTASection/__stories__/CTASection.stories.js b/packages/react/src/components/CTASection/__stories__/CTASection.stories.js index 566a8684641..2c3e524a4d0 100644 --- a/packages/react/src/components/CTASection/__stories__/CTASection.stories.js +++ b/packages/react/src/components/CTASection/__stories__/CTASection.stories.js @@ -1,5 +1,5 @@ /** - * Copyright IBM Corp. 2016, 2020 + * Copyright IBM Corp. 2016, 2021 * * This source code is licensed under the Apache-2.0 license found in the * LICENSE file in the root directory of this source tree. @@ -10,7 +10,7 @@ import CTASection from '../CTASection'; import React from 'react'; import readme from '../README.stories.mdx'; -const types = ['local', 'external', 'default']; +const types = ['local', 'external']; const contentItemsProps = [ { @@ -78,12 +78,12 @@ Default.story = { type: types[0], buttons: [ { - type: select('ContentBlock | CTA type', types, types[2], groupId), + type: select('ContentBlock | CTA type', types, types[0], groupId), copy: 'Secondary button', href: 'https://example.com/', }, { - type: select('ContentBlock | CTA type', types, types[2], groupId), + type: select('ContentBlock | CTA type', types, types[0], groupId), copy: 'Primary button', href: 'https://example.com/', }, @@ -137,12 +137,12 @@ WithContentItems.story = { type: types[0], buttons: [ { - type: select('CTA (type):', types, types[2], groupId), + type: select('CTA (type):', types, types[0], groupId), copy: 'Secondary button', href: 'https://example.com/', }, { - type: select('CTA (type):', types, types[2], groupId), + type: select('CTA (type):', types, types[0], groupId), copy: 'Primary button', href: 'https://example.com/', }, diff --git a/packages/react/src/components/CalloutData/CalloutData.js b/packages/react/src/components/CalloutData/CalloutData.js index e0878663ca2..5f1a8c3f2c3 100644 --- a/packages/react/src/components/CalloutData/CalloutData.js +++ b/packages/react/src/components/CalloutData/CalloutData.js @@ -1,5 +1,5 @@ /** - * Copyright IBM Corp. 2016, 2020 + * Copyright IBM Corp. 2016, 2021 * * This source code is licensed under the Apache-2.0 license found in the * LICENSE file in the root directory of this source tree. @@ -35,7 +35,7 @@ const CalloutData = ({ data, copy, source }) =>
    • ); -CalloutData.PropTypes = { +CalloutData.propTypes = { /** * Data for CalloutData pattern. */ diff --git a/packages/react/src/components/CardSectionCarousel/__stories__/CardSectionCarousel.stories.js b/packages/react/src/components/CardSectionCarousel/__stories__/CardSectionCarousel.stories.js index a2801801312..61abbb73237 100644 --- a/packages/react/src/components/CardSectionCarousel/__stories__/CardSectionCarousel.stories.js +++ b/packages/react/src/components/CardSectionCarousel/__stories__/CardSectionCarousel.stories.js @@ -27,7 +27,7 @@ export const Default = () => { This component is maintined in{' '} @carbon/ibmdotcom-web-components library with a{' '} React wrapper diff --git a/packages/react/src/components/CardSectionSimple/__stories__/CardSectionSimple.stories.js b/packages/react/src/components/CardSectionSimple/__stories__/CardSectionSimple.stories.js index 061c00e24af..e03b8d52bfb 100644 --- a/packages/react/src/components/CardSectionSimple/__stories__/CardSectionSimple.stories.js +++ b/packages/react/src/components/CardSectionSimple/__stories__/CardSectionSimple.stories.js @@ -40,7 +40,8 @@ export default { export const Default = ({ parameters }) => { const { heading, cards } = parameters?.props?.CardSectionSimple ?? {}; - const theme = document.documentElement.getAttribute('storybook-carbon-theme'); + const theme = + document.documentElement.getAttribute('storybook-carbon-theme') || 'white'; return ; }; diff --git a/packages/react/src/components/Carousel/__stories__/Carousel.stories.js b/packages/react/src/components/Carousel/__stories__/Carousel.stories.js index 32d5376c6da..fb3fdd5e2ff 100644 --- a/packages/react/src/components/Carousel/__stories__/Carousel.stories.js +++ b/packages/react/src/components/Carousel/__stories__/Carousel.stories.js @@ -1,5 +1,5 @@ /** - * Copyright IBM Corp. 2016, 2020 + * Copyright IBM Corp. 2016, 2021 * * This source code is licensed under the Apache-2.0 license found in the * LICENSE file in the root directory of this source tree. @@ -26,7 +26,7 @@ export const Default = () => { This component is maintined in{' '} @carbon/ibmdotcom-web-components library with a{' '} React wrapper diff --git a/packages/react/src/components/DotcomShell/DotcomShell.js b/packages/react/src/components/DotcomShell/DotcomShell.js index ce36688a157..26f0a0ecc78 100644 --- a/packages/react/src/components/DotcomShell/DotcomShell.js +++ b/packages/react/src/components/DotcomShell/DotcomShell.js @@ -1,5 +1,5 @@ /** - * Copyright IBM Corp. 2016, 2020 + * Copyright IBM Corp. 2016, 2021 * * This source code is licensed under the Apache-2.0 license found in the * LICENSE file in the root directory of this source tree. @@ -69,7 +69,7 @@ DotcomShell.propTypes = { }) ), }), - type: PropTypes.oneOf(['tall', 'short']), + type: PropTypes.oneOf(['tall', 'short', 'micro']), langCode: PropTypes.shape({ cc: PropTypes.string, lc: PropTypes.string, diff --git a/packages/react/src/components/Footer/LanguageSelector.js b/packages/react/src/components/Footer/LanguageSelector.js index c79d596c7bc..864fb974483 100644 --- a/packages/react/src/components/Footer/LanguageSelector.js +++ b/packages/react/src/components/Footer/LanguageSelector.js @@ -1,5 +1,5 @@ /** - * Copyright IBM Corp. 2016, 2020 + * Copyright IBM Corp. 2016, 2021 * * This source code is licensed under the Apache-2.0 license found in the * LICENSE file in the root directory of this source tree. @@ -91,6 +91,7 @@ const LanguageSelector = ({