Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown: Combobox & Multiselect]: Update Figma kit focus states #768

Closed
16 tasks done
Tracked by #6102
Kritvi-bhatia17 opened this issue Feb 21, 2024 · 1 comment
Closed
16 tasks done
Tracked by #6102

Comments

@Kritvi-bhatia17
Copy link

Kritvi-bhatia17 commented Feb 21, 2024

Before starting this issue check with dev & Michael :

For fluid styles:

  • Is it correct that the fluid dropdown does not get a focus state in the field when there is also a focus state on an item in the list? Looks like we have both focus states present in fluid multi-select and for the default dropdown and multi-selects. Not sure if that is an oversight or if there is a reason why it is different.

Regarding the focus state when expanding the dropdown:

  • Confirm if it is intentional for the focus state to be initially on the pre-selected item and whether it is designed to become unfocused as soon as the mouse exits the dropdown.
  • Explore the behavior when there is no default selection. Confirm whether any focus state is applied to options in this scenario.

All themes Figma library

  • Default Dropdown
    • Single-select
    • Multi-select
  • Fluid Dropdown
    • Single-select
    • Multi-select

  • Next step is to talk to Michael and other designer to decide & finalise on the dropdown's design interaction.

Michael suggestions :

Single select dropdown (both the default and fluid state) :

  • Parent component
    • No focus state when expanded
  • Child component
    • Focus state on the selected option.
    • If none selected, the first child has the focus state.
  • Persistence
    • Focus state remains as cursor moves out of the dropdown component.

Multi select dropdown (both the default and fluid state) :

  • Parent component
    • Focus state will be there when expanded as their is an interactive state within the parent's component
  • Child component
    • Focus state on the selected option.
    • If none selected, the first child has the focus state.
    • In case where multiple options are selected the focus state will be there for the first selected option
  • Persistence
    • Focus state remains as cursor moves out of the dropdown component.

Next step:

  • Update the parent's and child's focus state
  • Update all the inconsistencies, bugs, miss
    • Remove the hover state from the Dropdown - Combo box - Default & Fluid
    • Add focus and hover state in the Dropdown - Multi-select - Default & Fluid

Review

  • Review (accessibility expert/Michael)
  • Review (carbon designer)
@Kritvi-bhatia17
Copy link
Author

Kritvi-bhatia17 commented Mar 20, 2024

The solution

Ref : Figma branch link

Dropdown

  • In this case, the parent child will not have the focus state when expanded.

Default
image

Fluid
image


Dropdown - Combobox

  • Remove the hover state from the Dropdown - Combo box - Default & Fluid
  • The focus stroke or border of the parent state will be 1 px, while the stroke of the child state will be 2 px.

Default
image

Fluid
image


Dropdown - Multi-select

  • Add focus and hover state in the Dropdown - Multi-select - Default & Fluid
  • The focus stroke or border of the parent state will be 1 px, while the stroke of the child state will be 2 px.
  • The focus state for the child will be on the first selected option.

Default
image

Fluid
image

Filterable - Multi-select
image


@laurenmrice laurenmrice moved this from ✅ Done to 🏗 In Progress in Design System Mar 26, 2024
@Kritvi-bhatia17 Kritvi-bhatia17 modified the milestones: 2024 Q1, 2024 Q2 Mar 27, 2024
@thyhmdo thyhmdo moved this from 🏗 In Progress to ⏱ Backlog in Design System Mar 28, 2024
@Kritvi-bhatia17 Kritvi-bhatia17 moved this from ⏱ Backlog to 🏗 In Progress in Design System Apr 15, 2024
@laurenmrice laurenmrice moved this from Completed to Now in Roadmap Apr 29, 2024
@laurenmrice laurenmrice changed the title [Dropdown: Combobox & Multi-select] Update Figma Kit [Dropdown: Combobox & Multi-select] Update focus states Figma Kit May 6, 2024
@laurenmrice laurenmrice moved this from 🏗 In Progress to 🚦 In Review in Design System May 8, 2024
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System May 15, 2024
@github-project-automation github-project-automation bot moved this from Now to Completed in Roadmap May 15, 2024
@laurenmrice laurenmrice changed the title [Dropdown: Combobox & Multi-select] Update focus states Figma Kit [Dropdown: Combobox & Multiselect]: Update Figma kit focus states Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment