Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breadcrumb] fix state bugs #374

Closed
13 tasks done
laurenmrice opened this issue Oct 12, 2020 · 2 comments
Closed
13 tasks done

[breadcrumb] fix state bugs #374

laurenmrice opened this issue Oct 12, 2020 · 2 comments

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Oct 12, 2020

White theme:

  • Hover color for text needs to be hover-primary-text token.
  • Active underline needs to be text-01 token.
  • Focus needs to be a box instead of an underline. (box is 20px in height; 1px weight; type flush to border)

Gray 10 theme:

  • Hover color for text needs to be hover-primary-text token.
  • Active underline needs to be text-01 token.
  • Focus needs to be a box instead of an underline.

Gray 90 theme:

  • Hover value is wrong for the hover-primary-text token. It should be Blue 30
  • Focus needs to be a box instead of an underline.
  • Active underline needs to be text-01 token.

Gray 100 theme:

  • Hover value is wrong for the hover-primary-text token. It should be Blue 30
  • Focus needs to be a box instead of an underline.
  • Active underline needs to be text-01 token.
  • Current state needs to say "Current page" and not include the # character.
@stale
Copy link

stale bot commented Dec 13, 2020

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Dec 13, 2020
@laurenmrice
Copy link
Member Author

Fixed! Available in next update 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant