Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[checkbox] update focus style #339

Closed
aagonzales opened this issue Jul 13, 2020 · 7 comments
Closed

[checkbox] update focus style #339

aagonzales opened this issue Jul 13, 2020 · 7 comments

Comments

@aagonzales
Copy link
Member

Focus style of checkbox has recently been updated in code. Need to update symbol.
https://react.carbondesignsystem.com/?path=/story/checkbox--checked
image

@laurenmrice
Copy link
Member

  • White theme
  • Gray 10 theme
  • Gray 90 theme
  • Gray 100 theme

@mariuszmickiewicz
Copy link
Collaborator

In the code:

  • base component (checkbox + label) is 24px high with 4px margin below
  • checkbox icon is 16x16 (no 1px padding, which makes it 2px bigger than in the kit), with 24x24 container

In the kit:

  • base component is 20px high with 8px margin
  • checkbox icon is 16x16 (1px internal padding), 20x20 container

The easiest thing to do would be to add focus element which goes outside the checkbox artboard. This way it wouldn't break anything in the files where people already use it, but it also wouldn't count when measuring the spaces between the checkbox component and other ones.
Visually both versions would match (focus on both would go outside the grid), but still the way of measuring things would stay different.

image

@stale
Copy link

stale bot commented Sep 19, 2020

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Sep 19, 2020
@stale
Copy link

stale bot commented Oct 31, 2020

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale
Copy link

stale bot commented Dec 13, 2020

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the inactive label Dec 13, 2020
@laurenmrice
Copy link
Member

laurenmrice commented Jan 13, 2021

  • White theme
  • Gray 10 theme
  • Gray 90 theme
  • Gray 100 theme (in progress)

@laurenmrice
Copy link
Member

Fixed! Will be available in the next update 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants