Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short tag #23

Closed
vsnichols opened this issue Jul 16, 2019 · 3 comments
Closed

Short tag #23

vsnichols opened this issue Jul 16, 2019 · 3 comments

Comments

@vsnichols
Copy link

vsnichols commented Jul 16, 2019

Component name: tag

Why the change is necessary: The Carbon X tag is significantly taller (24px) than in Carbon 9 (20px). It does not fit comfortably into the short or compact data tables or the small search field, which means that those elements are unusable if tags need to be incorporated. We are proposing an 18px high tag to allow for sufficient spacing in both situations.

Research supporting change: We have heard from our users that they like data density, and that short tables help them scan information faster. During PUP, most users we talked with preferred the short table for resource list, which is why we implemented it. Many users we talk with seem to be using smaller desktop devices.

Screen Shot 2019-07-16 at 1 13 25 PM

Link: https://ibm.box.com/s/ni1eyykfn6k9k2h66jbzqpsev82c5snc

Screenshots of proposed design:

Screen Shot 2019-12-18 at 11 00 23 AM

image

Resource list with small tags in table and search/filter field

Contributing designer(s) & developer(s):

Designer: Virginia Nicholson
Developer: Trevor Wong, CloudPAL team

@vsnichols
Copy link
Author

@aagonzales Sorry I let this languish - updated the padding to 8px on both sides. I am going to try to work with Trevor to contribute this back to Carbon for January.

@aagonzales
Copy link
Member

Looks good to me! ✅

@laurenmrice
Copy link
Member

Closing, because this has been implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants