Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing aria label on batch action checkbox #834

Conversation

lee-chase
Copy link
Member

Closes #832

Add aria-label-for-batch-checkbox property to row and default

Changelog

M packages/core/src/components/cv-code-snippet/_cv-code-snippet-multiline.vue
M packages/core/src/components/cv-data-table/_cv-data-table-row-inner.vue
M packages/core/src/components/cv-data-table/cv-data-table-notes.md
M packages/core/src/components/cv-data-table/cv-data-table.vue
M storybook/stories/cv-data-table-story.js

@lee-chase lee-chase merged commit c2864fd into carbon-design-system:master Feb 25, 2020
@lee-chase lee-chase deleted the fixMissingAriaLabelBatchCheckbox branch February 25, 2020 13:32
@lee-chase lee-chase restored the fixMissingAriaLabelBatchCheckbox branch February 25, 2020 13:52
@lee-chase lee-chase deleted the fixMissingAriaLabelBatchCheckbox branch February 25, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch select checkboxes in CvDataTable have DAP violations
1 participant