Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filterable CvMultiSelect's Tag looks visually incorrect when there are 10 or more items selected #678

Closed
william-glasse opened this issue Nov 13, 2019 · 2 comments · Fixed by #963

Comments

@william-glasse
Copy link
Contributor

Detailed description

Describe in detail the issue you're having.

On the latest version of carbon-vue, when the CvMultiSelect component is made filterable, when there are more than 10 filters selected, the text of the Filter Tag overlaps with the field text.

Steps to reproduce the issue

  1. Step one
    Visit the storybook at http://vue.carbondesignsystem.com/?path=/story/components-cvmultiselect--default
  2. Step two
    Make the component filterable by selecting the filterable checkbox in the knobs section.
  3. Step three
    Select more than 10 items from the dropdown to observe unexpected results.

Additional information

Screenshot 2019-11-13 at 15 19 00

@william-glasse william-glasse changed the title Filterable CvMultiSelect's Tag looks visually incorrect when there are more than 10 items. Filterable CvMultiSelect's Tag looks visually incorrect when there are 10 ore more items selected Nov 13, 2019
@william-glasse william-glasse changed the title Filterable CvMultiSelect's Tag looks visually incorrect when there are 10 ore more items selected Filterable CvMultiSelect's Tag looks visually incorrect when there are 10 or more items selected Nov 13, 2019
@mrsideshowjack
Copy link
Contributor

mrsideshowjack commented Nov 13, 2019

It would also be good if the label didn't change to "Filter" when it's filterable, but keeps the label prop we input Fixed in pr

@lee-chase
Copy link
Member

This is a core carbon issue and needs raising there.

Will consider suggestions for a temporary fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants