fix: error due to l10n exported with "default" field. #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello! We have an error due to this part of code because it is outside the component and after build it causes error because this code use global l10n module in bundle with nested `default` filed. That is we should apply it like `l10n.default.en` and etc or replace this code into component module. Our team would be eternally grateful if you approve this pull request!
OhotnikovM
changed the title
OhotnikovM
changed the title
OhotnikovM
changed the title
|
✔️ Deploy Preview for carbon-components-vue ready! 🔨 Explore the source changes: e648a88 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-vue/deploys/6181758651559c0008f51e96 😎 Browse the preview: https://deploy-preview-1271--carbon-components-vue.netlify.app |
lee-chase
changed the title
lee-chase
approved these changes
Nov 2, 2021
|
@lee-chase Hello! It seems that i can't merge it myself due to protected branch. Could you merge it please? |
|
Will do. Just waiting for the ci/build to finish. Don't know why ci/circleci is still there. |
|
I got it. Thank you so much! |
lee-chase
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
We have an error due to this part of code because it is outside the component and after build it causes error because this code use global l10n module in bundle with nested
defaultfiled. That is we should apply it likel10n.default.enand etc or replace this code into component module.Our team would be eternally grateful if you approve this pull request!
Contributes to #
## What did you do?
defaultfiled. That is we should apply it likel10n.default.enand etc or replace this code into component module.## Why did you do it?
How have you tested it?
Were docs updated if needed?