feat: emit event on progress step click. update story book & update md #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for carbon-components-vue ready! 🔨 Explore the source changes: 257b47b 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-vue/deploys/60ec139714db9800082187df 😎 Browse the preview: https://deploy-preview-1219--carbon-components-vue.netlify.app |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to
What did you do?
Added an event to the cv-progress-step to emit an event if the step is clicked.
Why did you do it?
We did a usability test (usertesting.com) and found that most users want to use our progress bar as a secondary navigation. The progress bar steps already reacts to a hover but users were surprised that they could not click to advance the state.
Internally we have forked the cv-progress-step to resolve this:
How have you tested it?
Were docs updated if needed?