Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add show/hide events to cv-interactive-tooltip #1094

Merged
merged 4 commits into from
Jan 14, 2021

Conversation

davidnixon
Copy link
Collaborator

We had a use case in our app to animate a part of the page when the tooltip is shown and when the tooltip is hidden. There is not an easy way to do this without events emitted from the tooltip so I forked the component to use it in our app.

ToolTipEvent

Changelog

M packages/core/src/components/cv-tooltip/cv-interactive-tooltip.vue
M packages/core/src/components/cv-tooltip/cv-tooltip-notes.md

@netlify
Copy link

netlify bot commented Dec 16, 2020

✔️ Deploy preview for carbon-components-vue ready!

🔨 Explore the source changes: dbe5b68

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-vue/deploys/60003a0b1e94cf00075c39a9

😎 Browse the preview: https://deploy-preview-1094--carbon-components-vue.netlify.app

Copy link
Member

@lee-chase lee-chase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you add actions in storybook?

@davidnixon
Copy link
Collaborator Author

Looks good, could you add actions in storybook?

done

@davidnixon
Copy link
Collaborator Author

Looks good, could you add actions in storybook?

done

Actually let me re-work this to just have a show event with a true/false param. That would be cleaner.

@davidnixon
Copy link
Collaborator Author

Looks good, could you add actions in storybook?

done

Actually let me re-work this to just have a show event with a true/false param. That would be cleaner.

😃 OK last change. Really this time. I looked for other examples and found CVModal which also has a show/hide event so I used that as a model instead. It's still 2 different events but slightly renamed to match the CvModal pattern.


@lee-chase lee-chase merged commit 6670837 into carbon-design-system:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants