Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modal dialog labelledBy and aria-label to match react version #1070

Open
lee-chase opened this issue Nov 4, 2020 · 2 comments
Open
Labels
good first issue Good for newcomers

Comments

@lee-chase
Copy link
Member

There are discrepancies between how the modal handles aria-label, label and labelled by. Review and update Vue component.

@lee-chase lee-chase added the good first issue Good for newcomers label Nov 4, 2020
@ed2novoa
Copy link

ed2novoa commented Jan 7, 2021

Hi @lee-chase I think this issue is related to an existing accessibility bug found on version "2.36.0".

When analysing the open cv-modal on https://vue.carbondesignsystem.com/?path=/story/components-cvmodal--default with the "Axe" extension on chrome it detects this a11y issue:

image

That also corresponds to this MDN documentation: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/dialog_role
Under the "Description" section we find this bullet point: "The dialog must be properly labeled"

To fix this we will need a way to set custom values for aria-label, aria-labelledby and aria-describedby attributes for the element that has the role="dialog". (Maybe adding some props to the component to let the consumer to pass down the values).

I can help with the work needed to fix this issue. I just need more information to pin point all the existing "discrepancies" that need to be addressed. Please let me know. Thanks!

Copy link

This issue has been marked as stale because it has required additional
info or a response from the author for over 14 days. When you get the
chance, please comment with the additional info requested.
Otherwise, this issue will be closed in 14 days.

@github-actions github-actions bot added the stale 🍞 No recent activity label Jun 22, 2024
@davidnixon davidnixon removed the stale 🍞 No recent activity label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants