Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I don't get why changing the theme doesn't change the SideNav background-color #787

Closed
Pierre-Monier opened this issue Aug 12, 2021 · 3 comments
Labels
flagship Question for @carbon-design-system/carbon

Comments

@Pierre-Monier
Copy link

After testing CarbonTheme, I run through something weird. Changing theme as no effect on the SideNav background color 🤔 . It doesn't seem to be a bug, so I'm asking why it's working like that ? If the user choose to set a dark theme, I think it's annoying for him to have a full white SideNav component when he clicks on the hamburger menu. What was the idea behind that ?

I made a sandbox to demonstrate

@jazmik
Copy link
Contributor

jazmik commented Aug 13, 2021

The core carbon project haven't supported themes on the sidebar yet. See my response #762 (comment) to a similar question for a workaround.

@isrealbm
Copy link

isrealbm commented Sep 7, 2021

After testing CarbonTheme, I run through something weird. Changing theme as no effect on the SideNav background color 🤔 . It doesn't seem to be a bug, so I'm asking why it's working like that ? If the user choose to set a dark theme, I think it's annoying for him to have a full white SideNav component when he clicks on the hamburger menu. What was the idea behind that ?

I made a sandbox to demonstrate

Seem current version not has any props to do that, but you can change background by this way:

  :global(.bx--side-nav__navigation) {
    background-color: #111; /* Any HEX you want */
  }

  :global(.bx--side-nav__link .bx--side-nav__icon svg) {
    fill: #fff; /* Any HEX you want */
  }

@metonym metonym added the flagship Question for @carbon-design-system/carbon label Oct 4, 2021
@metonym
Copy link
Collaborator

metonym commented Oct 4, 2021

I believe the next major version of Carbon will support a theme-able UI Shell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flagship Question for @carbon-design-system/carbon
Projects
None yet
Development

No branches or pull requests

4 participants