Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination popups may need explicit background #712

Closed
brunnerh opened this issue Jun 30, 2021 · 7 comments
Closed

Pagination popups may need explicit background #712

brunnerh opened this issue Jun 30, 2021 · 7 comments

Comments

@brunnerh
Copy link
Contributor

Without hover the <select> has no background, leading to this for the dark themes on Chrome:

image

It works on Firefox but i do not know where that color is from:

image

The <Select> component always has a default background which prevents the problem altogether:

.bx--select-input {
    ...
    background-color: var(--cds-field,#f4f4f4);
    ...
}
@metonym
Copy link
Collaborator

metonym commented Jul 3, 2021

What OS and Chrome version are you using?

This is what I see on MacOS and Chrome 91:

pagination-chrome

@brunnerh
Copy link
Contributor Author

brunnerh commented Jul 3, 2021

@metonym
Windows 10 (version 20H2, build 19042.1052).
I guess this is a Windows-specific issue then, as those MacOS dropdowns look quite different.

@metonym
Copy link
Collaborator

metonym commented Jul 3, 2021

Interesting. Pagination uses Select, which uses the native select HTML element. That would explain the visual differences between browsers/operating systems.

@brunnerh
Copy link
Contributor Author

brunnerh commented Jul 4, 2021

(It is always good to use the native <select> if possible, though, due its high level of accessibility.)

@brunnerh
Copy link
Contributor Author

brunnerh commented Jul 4, 2021

Did not see the actual cause at first: For inline select components the background is explicitly set to transparent, otherwise it would be fine due to the default background from the .bx--select-input class:

.bx--select--inline .bx--select-input {
    ...
    background-color: transparent;
    ...
}

@metonym
Copy link
Collaborator

metonym commented Jul 4, 2021

Good eye. It might be worth raising this issue in the Carbon repo

@brunnerh
Copy link
Contributor Author

brunnerh commented Jul 5, 2021

Recorded as carbon-design-system/carbon#9112

@brunnerh brunnerh closed this as completed Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants