Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] Multi-sort feature enhancements #2398

Closed
1 of 4 tasks
davidicus opened this issue Jun 11, 2021 · 3 comments · Fixed by #2994
Closed
1 of 4 tasks

[Table] Multi-sort feature enhancements #2398

davidicus opened this issue Jun 11, 2021 · 3 comments · Fixed by #2994
Assignees
Labels
status: needs design 🎨 Items that require the input of a visual/ux designer type: enhancement 💡 New feature or request val: 3

Comments

@davidicus
Copy link
Collaborator

What package is this for?

  • React
  • Angular

Summary

These are copied from comment thread from this PR. There are many good suggestions to enhance the usability of this feature. The PAL design team will be taking a look at the existing spec and will take these features into consideration in their finalized spec.

  • If existing sorts exist, and I click the triple dot on a column that is not already sorted then it should add a new row and set that selected column in the dropdown.
  • Perhaps if I clicked a table column that is NOT sorted it might remove all other sorts, although I expect that customers would likely expect that action to just add another sorted column automatically.
@davidicus davidicus added type: enhancement 💡 New feature or request status: needs priority 📥 Enhancements without a `val #` label status: needs design 🎨 Items that require the input of a visual/ux designer labels Jun 11, 2021
@davidicus
Copy link
Collaborator Author

@dianatran18 FYI. These are some comments regarding enhancements to multi-sort that we should consider when design looks at this pattern.

@JordanWSmith15
Copy link
Collaborator

Relates to #2399

@kevinsperrine
Copy link
Collaborator

kevinsperrine commented Oct 19, 2021

@davidicus @dianatran18 These two additions were brought up by Sean in the original review. How should we handle these?

If existing sorts exist, and I click the triple dot on a column that is not already sorted then it should add a new row and set that selected column in the dropdown.

This one seems feasible. It could also happen if no sort exists, because the first sort option could be set to which-ever column they clicked the three-dot menu and chose multi-sort from.

Perhaps if I clicked a table column that is NOT sorted it might remove all other sorts, although I expect that customers would likely expect that action to just add another sorted column automatically.

Personally, I would expect clicking sort on a column that does not have multi-sort would sort by that column and clear the sorting on other columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs design 🎨 Items that require the input of a visual/ux designer type: enhancement 💡 New feature or request val: 3
Projects
None yet
3 participants