Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ComposedModal] Close button in incorrect position in RTL #2396

Closed
1 of 2 tasks
kevinsperrine opened this issue Jun 11, 2021 · 0 comments · Fixed by #3086
Closed
1 of 2 tasks

[ComposedModal] Close button in incorrect position in RTL #2396

kevinsperrine opened this issue Jun 11, 2021 · 0 comments · Fixed by #3086
Assignees
Labels
severity: 3 Affects minor functionality, has a workaround type: bug 🐛

Comments

@kevinsperrine
Copy link
Collaborator

What package is this for?

  • React
  • Angular

Describe the bug

When in RTL, the close button of the composed modal should appear on the left side. The padding of header should be adjusted, too.

To Reproduce

Go to any ComposedModal story and turn on RTL on the RTL storybook addon.

Expected behavior

The close button should move to the left side in RTL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity: 3 Affects minor functionality, has a workaround type: bug 🐛
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant