-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration Tests #136
Comments
Would you be interested in Cypress tests? It integrates nicely with Now deploys too. I can make a PR. |
@bahmutov Yes exactly! Cypress is definitely our best bet!!! That would be absolutely amazing. |
@mfix22 Are there still some tests that still needs to be done? I would love to work on it! |
@wuweiweiwu absolutely! We still need integrations tests for confirming the download button succeeds, and also testing Drag and drop. Tests for any of the settings would also be a bonus 😄 That would help tremendously! |
@mfix22 Awesome! ill get a pr out in the next couple of days! |
@mfix22 Currently working on the download test but its a little weird as it creates an I've tried synchronously querying the dom for https://docs.cypress.io/guides/core-concepts/conditional-testing.html#Dynamic-Text has been unsuccessful |
@wuweiweiwu is there a way to confirm that the download succeeds without checking for the existence of the cc @bahmutov |
@mfix22 I hope so the cypress documentation suggesting testing the mechanism of the actual download. But that doesn't seem to be helpful in this case. There also seems to be some cypress issues related to this cypress-io/cypress#949 |
Hi I'm new in Cypress and on Github. I am looking for a way to cut out a part of a called URL and save it in a variable that I can use elsewhere in the cypress test code. For example: |
@Franky82dev although this is outside the scope of this repo (: , you could just using normal JS variables like: const url = "http://something.com/The_Thing_I_need/somthing_else"
const extract = s => {
const m = /http:\/\/something\.com\/(.+)\/somthing_else/.exec(s)
return m && m[1]
}
const extracted = extract(url) // "The_Thing_I_need" or const url = "http://something.com/The_Thing_I_need/somthing_else"
const extract = s => s.split("//")[1].split('/')[1]
const extracted = extract(url) // "The_Thing_I_need" |
I'm closing this and will open a new one for a new test of integration tests. |
- [ ] Backspacing, typing works (I know, obvious)The text was updated successfully, but these errors were encountered: