Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Trezor Connect to 9.4.0+ #161

Open
kimlwh opened this issue Dec 13, 2024 · 4 comments
Open

Upgrade Trezor Connect to 9.4.0+ #161

kimlwh opened this issue Dec 13, 2024 · 4 comments

Comments

@kimlwh
Copy link

kimlwh commented Dec 13, 2024

Could Trezor Connect be upgraded to 9.4.7 (latest version as of today) or any version above 9.4.0?

Initializing newer versions of Trezor Connect with TrezorConnect.init({coreMode: "auto", ...}) now allows Trezor devices to be used without any local bridge software necessary, like the other devices Caravan supports. This is especially useful on platforms and devices where only the web is available or local software isn't, this compatibility has always been Caravan's biggest selling point as a stateless coordinator.

Was there a compatibility reason as to why Trezor Connect is frozen at version 9.1.12? I believe this is a worthwhile upgrade, the only meaningful one in fact since the current version Caravan is currently using.

Thank you.

@kimlwh kimlwh changed the title Trezor Connect Now Broken Trezor Connect Without Bridge Dec 13, 2024
@kimlwh kimlwh changed the title Trezor Connect Without Bridge Upgrade Trezor Connect to 9.4.0+ Dec 13, 2024
@bucko13
Copy link
Contributor

bucko13 commented Dec 13, 2024

Glad the problem isn't that trezor connect is now broken!

This does seem like a meaningful upgrade as well! Do you have a link to more docs on this upgrade? I didn't see anything in the 9.4.7 changelog.

Was there a compatibility reason as to why Trezor Connect is frozen at version 9.1.12?

No reason for that version in particular. That was just the last one we explicitly tested. The reason that we pinned though is that if we used the default to use the latest then trezor could inadvertently brick users since you access connect JIT and whatever version is latest is what you use. This has happened before where something was broken and users couldn't sign. We pinned to an earlier version in a release and reported the bug to trezor which was quickly released, but it felt like a precarious position to maintain so pinning and choosing to upgrade (and testing first) seemed preferable.

would you be willing to put up a PR that bumps the version? We can confirm everything still works and then upgrade.

@kimlwh
Copy link
Author

kimlwh commented Dec 13, 2024

Glad the problem isn't that trezor connect is now broken!

Yes I may have been confusing it with the development/hosted version that doesn't have cross-origin issues.

There doesn't seem to be much documentation other than the addition of the coreMode option which is documented under the init method TrezorConnect and in the changelog under 9.4.0.

would you be willing to put up a PR that bumps the version? We can confirm everything still works and then upgrade.

I will try, though I have no means of local development at the moment and little JavaScript knowledge. A couple of other changes are likely required such as removing the pinned connectSrc.

@bucko13
Copy link
Contributor

bucko13 commented Dec 17, 2024

Could you add a changeset version bump for caravan/wallets and caravan-coordinator. I think minor version for both makes sense as this is a new feature. See the readme here for more details

@kimlwh
Copy link
Author

kimlwh commented Dec 17, 2024

I've tried to use the editor GitHub has these days as I've no other options currently. Let me know if this is all acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants