Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea for new Export PSBT button to match functionality of Import PSBT button #111

Open
tomunchained opened this issue Jul 1, 2024 · 2 comments
Labels
@caravan/coordinator enhancement New feature or request good first issue Good for newcomers

Comments

@tomunchained
Copy link

It would be nice to have an "Export Current PSBT" button on the signing page, that includes any signatures that have already been gathered in the downloaded file (and one wouldn't need to unnecessarily enter the Coldcard flow).

That way, the file could be shared with a collaborative multisig parter, who uses the "Import PSBT" button to stage the transaction with all current progress, apply additional signatures, and then broadcast or continue to pass it along.

@bucko13 bucko13 added enhancement New feature or request good first issue Good for newcomers @caravan/coordinator labels Jul 1, 2024
@jevidon
Copy link
Collaborator

jevidon commented Jul 2, 2024

This option should appear on both the "Preview Transaction" page as well as the "Sign Transaction" page. Suggested locations marked in red on the following screenshots.

Stretch goal: update the CTA's on the "Sign Transaction" page to be the color button style as seen on the "Preview Transaction" page instead of just a text-based link.

Image

Image

@Shadouts
Copy link
Contributor

Shadouts commented Jul 9, 2024

I think it needs to retain the option to not include already gathered signatures. Including gathered signatures reveals information about who has signed and may not be desirable if the operator merely intends to gather signatures from other parties to combine and broadcast on their own. This can be easily achieved with an option menu (menu button).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@caravan/coordinator enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants