Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations #25

Open
seajaysec opened this issue Jun 12, 2020 · 9 comments
Open

Annotations #25

seajaysec opened this issue Jun 12, 2020 · 9 comments
Assignees

Comments

@seajaysec
Copy link

Would it be possible to add in the annotations that Brandon has on his site? I'd love to read those alongside the books right from my ereader.

https://www.brandonsanderson.com/brandon-sanderson-online-library/#annotations

@captn3m0
Copy link
Owner

captn3m0 commented Jul 7, 2020

I've read most of thee on the website, but this sounds doable. I'll get to it someday.

Since switching between 2 ebooks won't really be the best way, do you have any suggestions on how to approach this better?

@captn3m0 captn3m0 self-assigned this Jul 7, 2020
@BeeeWall
Copy link

BeeeWall commented Aug 12, 2020

The eBook versions of Warbreaker (at least from Google Play and Amazon) handle it by putting all the annotations at the end and putting a link to the annotations for each chapter at the start and end of said chapter, and a link back at the start and end of every annotation. But I don't know if that's something that'd be a pain to automatically (or worse manually) do for the books, don't really know enough of how this sort of thing works.

@captn3m0
Copy link
Owner

This does sound doable, however the problem becomes complicated because you need to supply the ebook yourselves, which makes it hard to get right. So far what this project does:

[Content on the internet] -> [this project] -> ebooks 🎉

But in this case, we need to do:

[original book] + [annotations from the internet] -> [annotated ebooks]

This project can't provide the original book (for obvious copyright reasons), but making sure that the code works with all ebooks across multiple publishers+editions without breaking formatting etc is going to be tough.

But it would be sooo cool to read!

@BeeeWall
Copy link

Yeah not sure how to do it, myself. Zero promises, but I might take a look at it, because I've been trying to get back into coding and this seems like something not too crazy. But then, I've never touched Ruby, so anything I make might be kinda ugly lol.

@captn3m0
Copy link
Owner

I just added annotation support to the Rhythm of War serialization. The annotations are picked from the reddit thread, which means I'll need to do a commit every week.

Please test and give feedback if this looks good?

@BeeeWall
Copy link

BeeeWall commented Sep 1, 2020

I've got a hastily-written thing set up to add annotations to the EPUB version of Elantris, but since I haven't used Ruby before, some things are horribly ugly (surely there's a way to append the Hash s I need to append without 7 (!) nested merge statements?), so I'll need to neaten it up a bit (or a lot) before uploading it.

Unfortunately, it will likely only work with specific EPUBs, and will need some tweaking to work on other books. But it's progress!

@captn3m0
Copy link
Owner

captn3m0 commented Sep 2, 2020

Neat-o! 🥇

Happy to merge this as an experimental feature whenever you're ready, and maybe work on making it more generic...

@BeeeWall
Copy link

BeeeWall commented Sep 2, 2020

Opened the PR earlier today at #32

Not really sure how to have it pass a file or anything, so currently it requires downloading the repo and running the script, since I don't think you can add a file to the Docker folder easily. But otherwise it works well, and I've neatened it up somewhat so it's not as horrendus.

Over the next few days I'll look into modifying it to work for the Mistborn books probably.

@BeeeWall
Copy link

Hmm. Just looked into adding annotations for the Mistborn books, but I just realized I only own the collections of 3 books rather than the individual eBooks, and so might not be able to do it. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants