Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to rename rbenv_map_bins to ruby_map_bins #90

Open
seuros opened this issue Apr 29, 2020 · 3 comments
Open

Proposal to rename rbenv_map_bins to ruby_map_bins #90

seuros opened this issue Apr 29, 2020 · 3 comments

Comments

@seuros
Copy link

seuros commented Apr 29, 2020

in https://github.com/capistrano/rvm we have rvm_map_bins
in https://github.com/capistrano/rbenv we have rbenv_map_bins
in https://github.com/capistrano/chruby we have chruby_map_bins

Any gem that try extend this arrays , will need to have 3 append to be compatible with all version managers.

I propose to soft deprecated the *_map_bins to ruby_map_bins .

If there is an approval, i will open a PR in the all the repos that are affected.

@mattbrictson
Copy link
Member

HI @seuros, I think it is safe to say that these gems are in maintenance mode and aren't being actively developed right now. This change would be a bit beyond my comfort level. Although I am a Capistrano maintainer, I am not familiar with this part of the Capistrano ecosystem (I have not used ruby version managers via Capistrano). I'll ping the other Capistrano maintainers to see if they have more context.

@leehambley @will-in-wi

@will-in-wi
Copy link
Contributor

This makes sense to me, as long as it's backwards compatible. It seems like a fairly simple change, which does help the further ecosystem.

I'm trying to think how this change might be made. Presumably, each gem would need to start referencing:

fetch(:ruby_map_bins, fetch(:rbenv_map_bins))

Where we still define the defaults in :rbenv_map_bins. We'd probably never be able to remove that indirection…

But it certainly does make everyone else's job easier, and the long term viability of this tool is very much related to the ease of the ecosystem.

I'd be inclined to accept such a PR.

@mpapis
Copy link

mpapis commented May 4, 2020

I'm all in (RVM).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants