Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRU-D implementation doesn't use input decay to mean #8

Open
Noahprog opened this issue Jun 8, 2020 · 0 comments
Open

GRU-D implementation doesn't use input decay to mean #8

Noahprog opened this issue Jun 8, 2020 · 0 comments

Comments

@Noahprog
Copy link

Noahprog commented Jun 8, 2020

Hi @caow13,

Hope you're doing well.
When going through your code I've noticed that in gru_d.py there is no input decay to mean. In the paper by Che et al here, the decayed input is described as:
Screenshot 2020-06-08 at 17 00 27
Where the second term contains the decay to last seen observation and the third term contains decay to empirical mean.

But in this implementation the code only does a decay to the last seen observation:
Screenshot 2020-06-08 at 17 01 02

It could be that this was intended. Anyway, hope you can find the time to look into this.
Gr,
Noah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant