added rateLimit parameter to the queue #1425
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a heavy user of
async.queue
, but if I am using it to queue calls to an API service which implements rate limiting (say 5 API calls per second), it becomes very tricky to get the queue to consume the queue within the rate limits.To fix this, I branched the code and added a new parameter to the queue object:
The queue works as normal but only proceeds at a maximum rate of 5 items per second.
The existing tests all pass and supplying a rateLimit of
null
or leaving it as undefined keeps the original queue unchanged.I've added a test for the rate-limited version.
(as this is my first commit to this project, I'm not sure if I should be including the "dist" files in the PR - please let me know if you would like these included too).