Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce package manager scaffolding. #1176

Merged
merged 1 commit into from
May 31, 2016
Merged

Reduce package manager scaffolding. #1176

merged 1 commit into from
May 31, 2016

Conversation

jdalton
Copy link
Contributor

@jdalton jdalton commented May 31, 2016

This PR tackles #1175.

@jdalton jdalton mentioned this pull request May 31, 2016
Closed
aearly
aearly reviewed May 31, 2016
View reviewed changes
support/xyz.sh
@@ -160,9 +158,6 @@ inc() {

inc package.json

run "$dir/sync-package-managers.js"
run "git add --force *.json"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we still need this line to stage changes to the package.json?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@aearly
Copy link
Collaborator

aearly commented May 31, 2016

I love PRs that remove 150 lines 😄

@aearly aearly merged commit f0ca1f7 into caolan:master May 31, 2016
@jdalton jdalton deleted the bower branch May 31, 2016 22:37
@megawac
Copy link
Collaborator

megawac commented Jun 3, 2016

+++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdalton @aearly @megawac