Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue concurrency #772

Merged
merged 4 commits into from
Jun 2, 2015
Merged

Queue concurrency #772

merged 4 commits into from
Jun 2, 2015

Conversation

justincy
Copy link
Contributor

@justincy justincy commented Jun 1, 2015

Fix for #747

@justincy
Copy link
Contributor Author

justincy commented Jun 1, 2015

Worked in node v0.10 but failed in v0.12 and iojs. I'll investigate.

@aearly aearly added the queue label Jun 1, 2015
});
setImmediate(q.process);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use async.setImmediate here, so it falls back to other methods when it's not available in the environment.

@aearly aearly added the bug label Jun 1, 2015
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 94.87% when pulling 02b715c on justincy:queue-concurrency into e2c5d6e on caolan:master.

@justincy
Copy link
Contributor Author

justincy commented Jun 2, 2015

@aearly Fixed.

aearly added a commit that referenced this pull request Jun 2, 2015
@aearly aearly merged commit ba7c7ba into caolan:master Jun 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants