New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make callback optional in whilst #642

Closed

jordanj77 wants to merge 1 commit into caolan:master from jordanj77:fix_446_whislt_callback

+1 −1

jordanj77 commented Oct 10, 2014

I believe that it's a best practice to make the callback optional.

This technique is used in core node libs (see https://github.com/joyent/node/tree/master/lib) as well as many popular community projects.

Fixes #446


          make callback optional in whilst

8571e50

aearly added the feature label

aearly closed this in

e37af8d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels