queue.remove() #1397
Merged
queue.remove() #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megawac
reviewed
Apr 9, 2017
lib/internal/DoublyLinkedList.js
Outdated
| return arr; | ||
| } | ||
|
|
||
| DLL.prototype.filter = function (testFn) { |
There was a problem hiding this comment.
Is this destructive? If so I'd rather not call it filter, but remove
There was a problem hiding this comment.
I wanted to call it filter so that if someone wants to swap out the implementation of _tasks with an array, they could. e.g.:
var q = async.queue(worker);
q._tasks = [];I remember we got an issue a while back after 2.0 because some people were doing custom splicing in the queue, which they couldn't do with the linked list.
It is strange that it doesn't return a new list (destructive) even though it's called filter, though.
There was a problem hiding this comment.
Actually after more thought, remove is a better name. If someone is using an array implementation, they're likely doing their own array splicing somehow anyway.
lib/internal/queue.js
Outdated
| remove: function (testFn) { | ||
| q._tasks = q._tasks.filter(function (node) { | ||
| return !testFn(node); | ||
| }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1391 .
Adds a
removefunction to queues. Without it, there is no way to arbitrarily remove items from the queue. In Async 1.x and below, thetaskslist was just an array, so you could splice as you needed. This adds afilterfunction to theDoublyLinkedListclass that is used byq.remove.I also added some unit tests for
DLLitself. I also noticed that the prior implementation ofemptycould cause a memory leak. I think the lingering chain ofprev/nextreferences could fool GC and keep the objects around.