-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform and Reduce argument order #1043
Comments
I'm +1 for |
+1 |
I'm having second thoughts as I started writing test cases. It's more logical I think to write var arr = [....]
async.transform(arr, {}, function(memo, v, k) {
memo[k] = v;
cb();
}, function() {
....
} then var arr = [....]
async.transform(arr, function(memo, v, k) {
memo[k] = v;
cb();
}, {}, function() {
....
} |
Yeah, the way it is now is easier to parse visually when you have an inline iteratee. I'm not sure what we should do here. |
I think we should err on the side of no breaking changes honestly |
Ok, then maybe we should keep the args ordering for |
See #892 for context
I am for
async.reduce(arr, iteratee, [accumulator,] callback)
/cc @aearly @qsona @suguru03
The text was updated successfully, but these errors were encountered: