Merge pull request #762 from VitoNordloh/master

intercept queue concurrency of 0. Fixes #714
caolan · May 20, 2015 · facb5cf · facb5cf
2 parents f5c6331 + 562f879
commit facb5cf
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/async.js b/lib/async.js
@@ -886,6 +886,9 @@
         if (concurrency === undefined) {
             concurrency = 1;
         }
+        else if(concurrency === 0) {
+            throw new Error('Concurrency must not be zero');
+        }
         function _insert(q, data, pos, callback) {
           if (!q.started){
             q.started = true;

diff --git a/test/test-async.js b/test/test-async.js
@@ -2453,6 +2453,13 @@ exports['queue default concurrency'] = function (test) {
     };
 };
 
+exports['queue zero concurrency'] = function(test){
+    test.throws(function () {
+        async.queue(function (task, callback) {}, 0);
+    });
+    test.done();
+};
+
 exports['queue error propagation'] = function(test){
     var results = [];