Merge pull request #827 from megawac/create-apply-each

Optimize applyEach* via creator function
caolan · Jul 2, 2015 · ac170ba · ac170ba
2 parents 69a3b67 + 0f8d920
commit ac170ba
Showing 1 changed file with 19 additions and 21 deletions.
diff --git a/lib/async.js b/lib/async.js
@@ -1147,29 +1147,27 @@
     };
 
 
-    var _applyEach = _restParam(function _applyEach(eachfn, fns, args) {
-        var go = _restParam(function(args) {
-            var that = this;
-            var callback = args.pop();
-            return eachfn(fns, function (fn, _, cb) {
-                fn.apply(that, args.concat([cb]));
-            },
-            callback);
+    function _applyEach(eachfn) {
+        return _restParam(function(fns, args) {
+            var go = _restParam(function(args) {
+                var that = this;
+                var callback = args.pop();
+                return eachfn(fns, function (fn, _, cb) {
+                    fn.apply(that, args.concat([cb]));
+                },
+                callback);
+            });
+            if (args.length) {
+                return go.apply(this, args);
+            }
+            else {
+                return go;
+            }
         });
-        if (args.length) {
-            return go.apply(this, args);
-        }
-        else {
-            return go;
-        }
-    });
+    }
 
-    async.applyEach = _restParam(function (args) {
-        return _applyEach.apply(null, [async.eachOf].concat(args));
-    });
-    async.applyEachSeries = _restParam(function (args) {
-        return _applyEach.apply(null, [async.eachOfSeries].concat(args));
-    });
+    async.applyEach = _applyEach(async.eachOf);
+    async.applyEachSeries = _applyEach(async.eachOfSeries);
 
 
     async.forever = function (fn, callback) {