once: ensure fn is gced

caolan · Jul 3, 2015 · 4027028 · 4027028
1 parent a835c67
commit 4027028
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/lib/async.js b/lib/async.js
@@ -39,20 +39,18 @@
     };
 
     function only_once(fn) {
-        var called = false;
         return function() {
-            if (called) throw new Error("Callback was already called.");
-            called = true;
+            if (fn === null) throw new Error("Callback was already called.");
             fn.apply(this, arguments);
+            fn = null;
         };
     }
 
     function _once(fn) {
-        var called = false;
         return function() {
-            if (called) return;
-            called = true;
+            if (fn === null) return;
             fn.apply(this, arguments);
+            fn = null;
         };
     }