🐞 fix: Fix improper memory span in Node.js mode

caoccao · Apr 9, 2024 · 8317c80 · 8317c80
1 parent 69a6372
commit 8317c80
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/cpp/jni/javet_jni_module.cpp b/cpp/jni/javet_jni_module.cpp
@@ -77,11 +77,17 @@ JNIEXPORT jobject JNICALL Java_com_caoccao_javet_interop_V8Native_moduleCreate
                     }
                 }
             }
+#ifndef ENABLE_NODE
             v8::MemorySpan<const V8LocalString> exportNamesMemorySpan(exportNames.begin(), exportNames.end());
+#endif
             auto v8LocalModule = v8::Module::CreateSyntheticModule(
                 v8Context->GetIsolate(),
                 Javet::Converter::ToV8String(jniEnv, v8Context, mModuleName),
+#ifdef ENABLE_NODE
+                exportNames,
+#else
                 exportNamesMemorySpan,
+#endif
                 Javet::Callback::JavetSyntheticModuleEvaluationStepsCallback);
             std::string stringKey("module:{}" + std::to_string(v8LocalModule->GetIdentityHash()));
             auto v8LocalStringKey = Javet::Converter::ToV8String(v8Context, stringKey.c_str());