Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finished Syncing notification #393

Closed
jake404 opened this issue Aug 8, 2017 · 7 comments
Closed

Finished Syncing notification #393

jake404 opened this issue Aug 8, 2017 · 7 comments

Comments

@jake404
Copy link

jake404 commented Aug 8, 2017

There is no global setting to disable the 'Finished Syncing' notification for all folders.

@canton7
Copy link
Owner

canton7 commented Aug 8, 2017

You are correct. There is however a single checkbox which will disable all folders at the same time. What is the issue?

@jake404
Copy link
Author

jake404 commented Aug 8, 2017

The above mentioned notifications are very annoying and having to change notifications for each folder on every computer is a pain. There are global settings for the other notifications so why not have one for this notification.

@canton7
Copy link
Owner

canton7 commented Aug 8, 2017

There isn't a "global" setting because the interaction of a global setting with per-folder settings is confusing for users. They enable the setting for a folder, yet there are no notifications: why? Then enable global notifications but some folders don't notify: why?

Other settings have only a global setting because noone requested a per-folder setting.

having to change notifications for each folder on every computer is a pain

As I said in my previous message, you can click a single checkbox to disable all folders at once. This one right here:

image

@jake404
Copy link
Author

jake404 commented Aug 8, 2017

Does that checkbox disable new folders as well? If so then the choice of UI components are unintuitive. Normally a checkbox above a list of checkboxes is a mass select/deselect only.

@canton7
Copy link
Owner

canton7 commented Aug 8, 2017

It is a mass deselect. Are you concerned about new folders, too? You didn't mention them.

Either way, a global setting as well as per-folder settings is not really viable, for the reasons I explained above. I can put some logic in which says "If we're adding a new folder, and the notifications for all previous folders are disabled, then initially disable notifications for this folder as well". At least what happened is clear to someone who views the settings.

@jake404
Copy link
Author

jake404 commented Aug 8, 2017

I feel that it would be more confusing that way. I would just use that top checkbox to disable all the checkboxes below it and also disable notifications completely. If that's not at all acceptable then your solution would be a decent compromise.

@canton7
Copy link
Owner

canton7 commented Aug 8, 2017

Cool. I'm pretty busy right now, but there will hopefully be another release within the next couple of months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants