Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update libraries and use JujuFacade in the charm #338

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

chore: Update libraries and use JujuFacade in the charm #338

wants to merge 8 commits into from
+652 −551

Conversation

saltiyazan
Copy link
Contributor

@saltiyazan saltiyazan commented Dec 9, 2024 •
edited
Loading

Description

This PR:

  • Updates the autounseal, vault-kv and juju-facade libraries.
  • Uses JujuFacade in the charm and refactors the charm.
  • Fixes unit and integration tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@saltiyazan saltiyazan force-pushed the TLSENG-545 branch 2 times, most recently from ae67f09 to bfe60cc Compare December 9, 2024 11:49
@saltiyazan saltiyazan changed the title Tlseng 545 chore: Tlseng 545 Dec 9, 2024
@saltiyazan saltiyazan changed the title chore: Tlseng 545 chore: Update libraries and use JujuFacade in the charm Dec 10, 2024
@saltiyazan saltiyazan force-pushed the TLSENG-545 branch 2 times, most recently from a3a825e to eca0329 Compare December 11, 2024 10:19
@DanielArndt DanielArndt mentioned this pull request Dec 11, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@saltiyazan