Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs reference non-existing setting font-base-size #5375

Open
apollo13 opened this issue Oct 10, 2024 · 2 comments
Open

Docs reference non-existing setting font-base-size #5375

apollo13 opened this issue Oct 10, 2024 · 2 comments
Labels
Bug 🐛 Documentation 📝 Documentation changes or updates P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4

Comments

@apollo13
Copy link

Describe the bug

https://vanillaframework.io/docs/settings/font-settings references $font-base-size, but I can only find

$base-font-sizes: (
  base: 1rem,
  large: $font-size-largescreen,
) !default;

in the source.

Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-15777.

This message was autogenerated

@bartaz
Copy link
Member

bartaz commented Oct 10, 2024

Thanks @apollo13! Seems like we missed that when we were refactoring the font variables in the past.

Indeed font sizes are now provided by this map, with one base value and one we use on very large screens.

@bartaz bartaz added Documentation 📝 Documentation changes or updates P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4 labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Documentation 📝 Documentation changes or updates P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4
Projects
None yet
Development

No branches or pull requests

2 participants