Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme link colours might not be readable/accessible #4844

Closed
juanruitina opened this issue Jul 24, 2023 · 1 comment
Closed

Dark theme link colours might not be readable/accessible #4844

juanruitina opened this issue Jul 24, 2023 · 1 comment

Comments

@juanruitina
Copy link

The shade of blue (#6699cc) and purple (#a679d2) used for links in the dark theme might make text not readable enough. The colour combinations with the graphite background (#262626) definitely comply with the WCAG algorithm (AAA actually), but:

  1. We received feedback from a colleague that contrast is too low on canonical.com; I had the same intuition. Given contrast is heavily perceptual, users' perceptions should be taken into consideration.
  2. The WCAG algorithm is known to throw false positives in many instances and for blues in particular (one source), because blue has low luminance.
  3. The combination fails the APCA algorithm (blue on graphite, purple on graphite), particularly given the very thin font weight we are using. Even if it's not the official algorithm, I would take this as another sign something is wrong with the colour combination.

For context, here's Github's own discussion around the topic. They agree it's a tough one. I agree that "Visual task of differentiation is not all the same as the visual task of fluent readability" (a comment by the way made by the proponent of the APCA algorithm). It is a tradeoff, and I am on the side of ensuring readability, as differentiation can be achieved in other ways (e.g. positioning, underlining).

I acknowledge this is difficult to address, as we might need to choose between compliance and actual accessibility; this is something we have discussed a few times already. But wanted to document this nonetheless.

Some more reads:

When did the issue start? Vanilla 4.0.0
To reproduce: visit canonical.com, such links are used across the page and in the Careers navigation item.

canonical com_(Desktop)
canonical com_(Desktop) (1)

@juanruitina
Copy link
Author

Duplicate of #4633

@juanruitina juanruitina marked this as a duplicate of #4633 Jul 24, 2023
@juanruitina juanruitina closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant