Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom is-ticked list with new Vanilla component on Azure page(s) #14173

Open
pastelcyborg opened this issue Aug 13, 2024 · 1 comment
Assignees

Comments

@pastelcyborg
Copy link
Contributor

Summary

In order to match the desired design, the team has utilized a series of p-list--divided components with the is-ticked boolean on its child items:

https://github.com/canonical/ubuntu.com/blob/cloud-bubble-refresh/templates/azure/sql.html#L51

Unfortunately, achieving this required the use of grid classes mixed with list items, which probably has unintended effects for one or both components.

Expected behavior

Optimally, Vanilla makes available a new component that looks and functions as the desired design here. An Issue has already been filed against Vanilla to add such a component:

canonical/vanilla-framework#5293

Once this component has been added, it should be used here on ubuntu.com as well, rather than the current solution, and this Issue should track this work.

@pastelcyborg pastelcyborg self-assigned this Aug 13, 2024
@lizzochek
Copy link
Contributor

@pastelcyborg thank you for rising this issue, we will replace the component as soon as Vanilla provides us with one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants