Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-5036][DPE-3666] Create s3 bucket if not existing #58

Merged
merged 10 commits into from
Dec 11, 2024
Merged

[DPE-5036][DPE-3666] Create s3 bucket if not existing #58

merged 10 commits into from
Dec 11, 2024

Conversation

Batalex
Copy link
Contributor

@Batalex Batalex commented Dec 4, 2024

Changes:

@Batalex Batalex self-assigned this Dec 4, 2024
@Batalex Batalex marked this pull request as ready for review December 5, 2024 11:52
Batalex
Batalex commented Dec 5, 2024
View reviewed changes
tests/integration/test_helpers.py Outdated Show resolved Hide resolved
tests/unit/test_component_s3.py Show resolved Hide resolved
theoctober19th
theoctober19th approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@theoctober19th theoctober19th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, Alex! The PR LGTM, I have left a few suggestions here and there.

src/managers/s3.py Outdated Show resolved Hide resolved
tests/integration/test_helpers.py Outdated Show resolved Hide resolved
tests/unit/test_component_s3.py Show resolved Hide resolved
@Batalex Batalex changed the title [DPE-5036] Create s3 bucket if not existing [DPE-5036][DPE-3666] Create s3 bucket if not existing Dec 9, 2024
welpaolo
welpaolo approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@welpaolo welpaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work! let's replicate this for the azure storage :)

@Batalex Batalex merged commit 2945bb6 into main Dec 11, 2024
11 checks passed
@Batalex Batalex deleted the dpe-5036-s3-bucket branch December 11, 2024 09:09
@Batalex Batalex mentioned this pull request Dec 12, 2024
Merged
@Batalex Batalex linked an issue Dec 17, 2024 that may be closed by this pull request
Spark history server unit BLOCKED - Missing S3 relation #31
Open
@Batalex Batalex mentioned this pull request Dec 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theoctober19th theoctober19th theoctober19th approved these changes

@welpaolo welpaolo welpaolo approved these changes

Assignees

@Batalex Batalex

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Batalex @welpaolo @theoctober19th