feat(personality): Allow state filename customization #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhoyt
reviewed
May 9, 2024
| @@ -22,3 +22,6 @@ var DisplayName string = "Pebble" | |||
|
|
|||
| // DefaultDir is the Pebble directory used if $PEBBLE is not set. | |||
| var DefaultDir string = "/var/lib/pebble/default" | |||
|
|
|||
| // StateFile is the file name of the state file in pebble dir. | |||
| var StateFile string = ".pebble.state" | |||
There was a problem hiding this comment.
I guess having a separate StateFile variable is better than using "."+ProgramName+".state"?
There was a problem hiding this comment.
Yes, it'd allow us to be more flexible with the file name selection (e.g. could be a non-hidden file or a different filename extension, etc..).
benhoyt
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to customize the state file name, which is part of the personality (application name, pebble dir, ...).