You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@flotter and @anpep have an outstanding task to refactor the client test framework to better utilise the Requester interface (#310). At the moment the test framework cannot use Requester Do() due to client.response type not used in the response body. We should also ensure all areas are properly covered.
The text was updated successfully, but these errors were encountered:
func (client *Client) SetDoer(d doer) {
client.doer = d
client.Requester().(*defaultRequester).doer = d
Should this SetDoer method be moved to a test method/function? I believe external packages can't actually call it anyway, as the doer interface isn't exported. But happy to leave this to another PR if you prefer.
It looks like we're never setting the baseURL field -- oversight? We do use it in dispatch (somewhat surprised there's not a test for this -- we should probably add one).
benhoyt
changed the title
Refactor client test framework once Requester #310 is merged
Refactor client test framework now that Requester is merged
May 17, 2024
@flotter and @anpep have an outstanding task to refactor the client test framework to better utilise the Requester interface (#310). At the moment the test framework cannot use
Requester Do()
due toclient.response
type not used in the response body. We should also ensure all areas are properly covered.The text was updated successfully, but these errors were encountered: