Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new Pebble types for log forwarding #1026

Closed
benhoyt opened this issue Oct 2, 2023 · 2 comments
Closed

Add new Pebble types for log forwarding #1026

benhoyt opened this issue Oct 2, 2023 · 2 comments
Labels
feature New feature or request small item

Comments

@benhoyt
Copy link
Collaborator

benhoyt commented Oct 2, 2023

ops/pebble.py does not have newly-added types and typed dicts for the log forwarding work.

Specifically, we're missing the top-level log-targets mapping on the plan. See Pebble's plan.go.

We should get these added (and make sure any other new fields in the Pebble plan are in there too).
@benhoyt benhoyt added feature New feature or request small item labels Oct 2, 2023
@tonyandrewmeyer
Copy link
Contributor

#1073 was a dupe of this, but we missed that at the time. I did also look over the Pebble plan at the time and nothing else seemed to be missing.

@benhoyt
Copy link
Collaborator Author

benhoyt commented Dec 10, 2023

Excellent, thanks Tony. Fixed by PR #1026 -- closing.

@benhoyt benhoyt closed this as completed Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request small item
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tonyandrewmeyer @benhoyt